Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7560/3/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java: Line 527: return !kuduConjuncts_.isEmpty(); nit oneline http://gerrit.cloudera.org:8080/#/c/7560/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: PS3, Line 219: (){ > nit: missing space You are correct, that should be fixed as well. http://gerrit.cloudera.org:8080/#/c/7560/3/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: PS3, Line 1019: self.client.execute("set explain_level=3") you can actually use client.set_configuration(config_map) e.g. from test_ddl.py: def test_sync_ddl_drop(self, vector, unique_database): """Verifies the catalog gets updated properly when dropping objects with sync_ddl enabled""" self.client.set_configuration({'sync_ddl': 1}) # Drop the database immediately after creation (within a statestore heartbeat) and # verify the catalog gets updated properly. self.client.execute("drop database {0}".format(unique_database)) PS3, Line 1024: assert str(result).find("hosts=3 instances=3") != -1 the more python-y way to say this is assert "hosts..." in str(result) -- To view, visit http://gerrit.cloudera.org:8080/7560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
