Tim Armstrong has posted comments on this change. Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query ......................................................................
Patch Set 3: (3 comments) Looking pretty good. http://gerrit.cloudera.org:8080/#/c/7560/3/fe/src/main/java/org/apache/impala/planner/ScanNode.java File fe/src/main/java/org/apache/impala/planner/ScanNode.java: Line 219: public boolean hasPushedConjuncts(){ I think DataSourceScanNode can also push conjuncts. The distinction might not be important for now since I believe that always runs on the coordinator but should probably be precise. PS3, Line 219: (){ nit: missing space http://gerrit.cloudera.org:8080/#/c/7560/3/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 1007: def test_missing_table_stats(self, cursor, kudu_client, unique_database): This needs @SkipIfNotHdfsMinicluster.plans since it's assuming a 3 node minicluster. -- To view, visit http://gerrit.cloudera.org:8080/7560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I93822d67ebda41d5d0456095c429e3915a3f40c4 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
