Tim Armstrong has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options ......................................................................
Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/7805/7/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: PS7, Line 39: i32_max Constants should be upper case, i.e. I32_MAX. PS7, Line 49: MakeOk Maybe MakeOkTest or MakeTestOkFn? It would make it clearer that this returns a function. PS7, Line 65: KEY MAKE_KEYDEF seems clearer to me. PS7, Line 90: uint64_t Use static_cast<uint64_t>() PS7, Line 182: Entry ENTRY PS7, Line 184: Entries ENTRIES Line 198: auto enum_and_int = fusion::make_tuple( Does std::make_tuple not work here? Line 306: #undef KEY It seems ok to leave this macro defined for the rest of the file. -- To view, visit http://gerrit.cloudera.org:8080/7805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
