Tim Armstrong has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options ......................................................................
Patch Set 8: (4 comments) I'm generally ok with this patch. I think there are places where there's a trade-off between using macros/lambdas and repeating ourselves. My general feeling is that there wouldn't be a net improvement to the code by changing that, but I'm ok with whatever Lars and Tianyi figure out. http://gerrit.cloudera.org:8080/#/c/7805/8/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: PS8, Line 67: SetNonExistOptions) SetNonExistentOptions. Line 124: {MAKE_KEYDEF(max_row_size), {1, I64_MAX}}, Should add DEFAULT_SPILLABLE_BUFFER_SIZE and MIN_SPILLABLE_BUFFER_SIZE. Those might require some additional logic since they're restricted to power-of-twos. Line 175: // ENTRIES(TPrefetchMode, (None)(HT_BUCKET)) expands to Can you add blank lines after the macro definitions? It's a bit hard to see which comment goes with which macro currently. PS8, Line 219: err It might be clearer to call these functions something like TestError() and TestOk(). I don't feel strongly though - this seems readable enough to me. -- To view, visit http://gerrit.cloudera.org:8080/7805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
