Tianyi Wang has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options ......................................................................
Patch Set 7: (11 comments) http://gerrit.cloudera.org:8080/#/c/7805/7/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: PS7, Line 39: i32_max > Constants should be upper case, i.e. I32_MAX. Done PS7, Line 49: MakeOk > Maybe MakeOkTest or MakeTestOkFn? It would make it clearer that this return Done PS7, Line 65: KEY > MAKE_KEYDEF seems clearer to me. Done Line 81: auto lb = test_case.second.first; > No. Will fix. Done PS7, Line 90: uint64_t > Use static_cast<uint64_t>() Done Line 103: for (auto& value : common_value) { > Will fix. Done PS7, Line 182: Entry > ENTRY Done PS7, Line 184: Entries > ENTRIES Done Line 198: auto enum_and_int = fusion::make_tuple( > Does std::make_tuple not work here? It didn't though boost claims it should. Line 198: auto enum_and_int = fusion::make_tuple( > Could we avoid the use of tuples here if we changed TestEnumCaseSet to just Done. Line 306: #undef KEY > It seems ok to leave this macro defined for the rest of the file. Removed. -- To view, visit http://gerrit.cloudera.org:8080/7805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
