Tianyi Wang has posted comments on this change. Change subject: IMPALA-5425: Add test for validating input when setting query options ......................................................................
Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/7805/8/be/src/service/query-options-test.cc File be/src/service/query-options-test.cc: PS8, Line 67: SetNonExistOptions) > SetNonExistentOptions. Done Line 124: {MAKE_KEYDEF(max_row_size), {1, I64_MAX}}, > Should add DEFAULT_SPILLABLE_BUFFER_SIZE and MIN_SPILLABLE_BUFFER_SIZE. Tho They are in SetSpecialOptions. Line 175: // ENTRIES(TPrefetchMode, (None)(HT_BUCKET)) expands to > Can you add blank lines after the macro definitions? It's a bit hard to see Done PS8, Line 219: err > It might be clearer to call these functions something like TestError() and Done. -- To view, visit http://gerrit.cloudera.org:8080/7805 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I510e02bb0776673d8cbfc22b903831882c6908d7 Gerrit-PatchSet: 8 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
