Caideyipi commented on PR #19053:
URL: https://github.com/apache/iotdb/pull/19053#issuecomment-6490737483

   Initial independent self-review completed at head 
1722b533d1c296dd10a804dc73922112b88434ef, against master base 
a927dd6bc63af2457818a54e96fbcb4986bf7c87.
   
   I reviewed the complete two-file diff and the surrounding historical 
extraction, progress filtering, Pipe checkpoint commit ordering, TsFile 
progress persistence, and Ratis recovery/snapshot paths. No actionable 
source-behavior or test-logic issues were found, so no fixes were needed.
   
   The dedicated clean DataNode dependency-closure build and Spotless 
validation passed, and PipeHistoricalDataRegionTsFileAndDeletionSourceTest 
passed all 21 tests with 0 failures, errors, or skips, including the added 
Ratis regression. The added regression was not run in this local review 
session. GitHub CI is reported separately: some checks are still in progress, 
and SonarCloud Code Analysis failed on findings outside the files changed by 
this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to