Caideyipi commented on PR #19053: URL: https://github.com/apache/iotdb/pull/19053#issuecomment-6516250661
Independent re-review of `d1b7ed27b50d533bff54aa37b5453bfb2d7abbd5` found five behavioral gaps. They are fixed in `eab49c25efe9cf004dc84f2c28ea2216b2b0c6c5`: 1. **Legacy receiver bypass.** File-piece and TsFile-seal requests did not pass through the modern receiver's Ratis restriction. Reject both before file writes, rename, or loading, while retaining the legacy handshake and deletion path. `iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/legacy/IoTDBLegacyPipeReceiverAgent.java:169,279`. 2. **Different inclusion semantics.** The guard used prefix matching different from the actual data-region listener: `data.insert.extra` could bypass rejection, and the same exclusion could cause a false rejection. Use a shared predicate matching `DataRegionListeningFilter`. `iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/datastructure/options/PipeInclusionOptions.java:260`. 3. **ConfigNode task recovery.** The ConfigNode task agent inherited the permissive default, allowing metadata tasks of persisted insertion-containing Pipes to run under Ratis. Apply the task eligibility gate during recovery and metadata updates. `iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/agent/task/PipeConfigNodeTaskAgent.java:72`. 4. **Completed subscription snapshot recovery.** Single/full metadata restoration could recreate a completed-empty-snapshot broker after the task layer ignored the forbidden subscription Pipe. Apply the subscription feature gate before broker restoration. `iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/task/PipeDataNodeTaskAgent.java:273`. 5. **Concurrent partial ALTER.** Two requests could each pass against the initial RPC snapshot but merge into insertion-containing attributes under the procedure lock. Revalidate the final merged attributes in the existing locked validators, covering CREATE and both START variants as well. `iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/pipe/PipeTaskInfo.java:315,432`. Ratis itself uses Raft log replication and has no consensus-internal Pipes; internal Pipe compatibility was checked with IoTConsensusV2. The regression coverage also checks permitted metadata/deletion Pipes, rejected file-transfer side effects, and absence of a restored subscription broker. No independent assertion or test-logic defect was identified in the original PR tests. Validation: - Spotless with the `with-integration-tests` profile and `git diff --check` passed. - A clean source build of the three affected modules and their complete 29-module IoTDB dependency closure passed with the English locale. Seven selected test classes ran 61 tests: zero failures, errors, or skips. All tests newly added in this round ran locally. - The same clean source dependency closure passed `test-compile -P with-zh-locale -DskipTests`. Build caches were disabled for both runs. - Verification ran locally after remote toolchain setup failed due to a TLS download error. These checks do not represent a whole-repository test or integration-test run. Reviewed SHA: `d1b7ed27b50d533bff54aa37b5453bfb2d7abbd5`. Final local SHA, confirmed source-branch SHA, and confirmed PR head: `eab49c25efe9cf004dc84f2c28ea2216b2b0c6c5`. The PR remains Draft, and its description was not changed. This round found behavioral issues; successful repair validation does not constitute a fresh issue-free independent review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
