Caideyipi commented on PR #19053: URL: https://github.com/apache/iotdb/pull/19053#issuecomment-6517441433
Independent re-review completed (one round). - Reviewed SHA: `f6dedbdddf584d1be959bd3a38bdb1f262c93191`. - Final local SHA and confirmed source-branch/PR head: `f6dedbdddf584d1be959bd3a38bdb1f262c93191`. - Scope: the complete 34-file diff against `master` (merge base `28c5028bb462403315e46319b57e9beb96ffaa69`; fetched master `3a51384b2dcc8c29118b7d082c829450c4408b4c`), including all earlier changes, the latest fixes, relevant callers/configuration, and changed test logic. Reviewed CREATE/ALTER/START and procedure locking, recovery and lifecycle, Subscription client/internal RPC paths, inclusion/exclusion matching, metadata/deletion compatibility, IoTConsensusV2 internal Pipes, and legacy/Thrift/air-gap/compressed/sliced receiver paths. - Findings: no actionable source-behavior or test-logic issues found. No fixes, source/test edits, new tests, commits, pushes, or PR-description changes were needed. - Validation this round: three-module offline Spotless check passed (JDK 17, Maven exit 0; unchanged-file cache used); full-diff whitespace checks passed; static checks passed for the two new bilingual message constants and all 12 Tablet/TsFile request types. Test fixtures, serialization paths, lifecycle assertions, execution-boundary counters, and configuration restoration were independently inspected. - Compilation and executable tests were not rerun because no code or test changed. The previously reported 29-module build and nine suites / 108 passing tests remain historical validation, not results from this round. No new unrun tests were introduced. - Remote CI: no check runs or individual commit statuses were returned for this SHA; combined status was `pending`. This is not counted as passing CI. - The source branch and PR head were reconfirmed unchanged. The PR remains **Draft** as requested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
