Caideyipi commented on PR #19053:
URL: https://github.com/apache/iotdb/pull/19053#issuecomment-6574711641

   Review feedback update, starting from 
`7936b04cea75395dcf3e65cfcde89b7a7c04ec65`:
   
   - Confirmed that the redundant consensus-Pipe exemptions were already 
removed in `7936b04` because IoTConsensusV2 and Ratis are mutually exclusive.
   - Changed `isDataInsertionRequest` to an exhaustive switch expression 
without a default, explicitly covering all 25 current request types.
   - Shared the subscription configuration/Ratis predicate between 
timeout-checker scheduling and the dynamic subscription-enabled supplier.
   - Merged current `master` (`1b2158fec358ed9952f5cbca2bc1387dd46b3419`) in 
`e0fde549870`. The only manual conflict was in `PipeTaskInfo` imports; both 
sides' required imports were retained. GitHub now reports the PR as mergeable.
   
   Validation completed locally with JDK 17:
   
   - Spotless apply passed for Node Commons, DataNode and ConfigNode with the 
`with-integration-tests` profile.
   - The clean 29-module ConfigNode/DataNode source dependency closure passed, 
with build caches disabled.
   - All 41 tests in `IoTDBDataNodeReceiverTest` (24), 
`SubscriptionReceiverAgentTest` (15) and `PipeTaskInfoRatisTest` (2) passed, 
with zero failures, errors or skips.
   - Full PR whitespace checks passed. No tests were added or changed in this 
update. Chinese-locale compilation, whole-repository tests and integration 
tests were not rerun in this update.
   
   Final local commit and confirmed source-branch/PR head: 
`35f1f0cd86381fc3242ab5f5add948130fec4406`. The update was pushed successfully. 
This session applied review feedback and did not perform a complete independent 
re-review. The PR remains Draft pending a fresh independent review of the 
updated head. All three reviewer threads are left unresolved as requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to