Caideyipi commented on PR #19053:
URL: https://github.com/apache/iotdb/pull/19053#issuecomment-6517109695

   Independent re-review completed in one round.
   
   Reviewed SHA: `eab49c25efe9cf004dc84f2c28ea2216b2b0c6c5`. I independently 
inspected the complete diff against `master`, including previous fixes, and 
traced configuration, option matching, creation/alter/start, locked validation, 
recovery, subscription lifecycle/internal RPCs, receiver protocol envelopes, 
and the changed tests. The review also covered metadata/delete-only Pipes, 
non-Ratis protocols, and IoTConsensusV2 internal consensus Pipes; Ratis itself 
has no internal consensus Pipe.
   
   Found and fixed two behavioral issues:
   
   1. **Concurrent DROP could make ALTER/START throw a null-pointer 
exception.** The existence check and metadata read held separate locks, so DROP 
could remove the metadata between them, including under non-Ratis protocols. 
Both operations now use one nullable metadata snapshot and retain the expected 
missing-Pipe/ALTER IF EXISTS statuses. See 
[ALTER](https://github.com/apache/iotdb/blob/f6dedbdddf584d1be959bd3a38bdb1f262c93191/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/task/PipeTaskCoordinator.java#L245)
 and 
[START](https://github.com/apache/iotdb/blob/f6dedbdddf584d1be959bd3a38bdb1f262c93191/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/task/PipeTaskCoordinator.java#L298).
 A deterministic regression performs an actual DROP before lookup across four 
protocols and both models (24 cases).
   2. **Insertion PlanNodes could bypass the Ratis restriction through 
TRANSFER_PLAN_NODE.** That generic request accepts insertion nodes but was 
outside the dedicated tablet/TsFile request-type filter. The receiver now 
rejects InsertNode before statement conversion/execution using the existing 
localized response. See [the admission 
check](https://github.com/apache/iotdb/blob/f6dedbdddf584d1be959bd3a38bdb1f262c93191/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/thrift/IoTDBDataNodeReceiver.java#L1062).
 Regressions cover four insertion node forms and plain, AirGap, compressed and 
sliced envelopes, plus allowed metadata/delete and non-Ratis insertion paths, 
with execution-entry assertions.
   
   Validation: Spotless apply and diff checks passed. The 29-module source 
dependency closure was rebuilt from clean source; after correcting the new test 
fixture's Mockito compatibility and model dialect setup, ConfigNode was cleaned 
and rebuilt and the final 29-module reactor passed. All **108 tests in nine 
suites passed**, with zero failures, errors or skips. All newly added tests 
were run locally. The remote attempt failed resolving a Maven extension before 
compilation; validation completed locally with JDK 17. This was focused 
unit-test/dependency-closure validation. Chinese-locale compilation was not 
repeated this round; no localization constants or cross-module APIs changed.
   
   Final local SHA: `f6dedbdddf584d1be959bd3a38bdb1f262c93191`.
   Confirmed remote source branch and PR head: 
`f6dedbdddf584d1be959bd3a38bdb1f262c93191` 
(`codex/ratis-historical-replay-20261029`). The update was pushed successfully, 
and the PR remains **Draft**. Its description was unchanged. These behavioral 
findings require a fresh independent review; repair verification in this 
session was not a second review round.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to