Caideyipi commented on PR #19186:
URL: https://github.com/apache/iotdb/pull/19186#issuecomment-6786807775

   Scoped re-review: column deletion progress.
   
   Confirmed and fixed the missing observability for `ALTER TABLE ... DROP 
COLUMN`: previously `DESCRIBE ... DETAILS` exposed only `DELETING`, without a 
procedure list, execution phase, errors, or mod-file counts.
   
   The new `information_schema.drop_table_column_procedures` table reports 
database/table/column, procedure ID, state, phase, errors, and 
written/remaining mod-file counts. It shares aggregation and persistence with 
`DROP TABLE`: one executing replica per Region contributes, unknown counts stay 
`NULL`, and completed procedures remain visible under the existing retention 
policy. Attribute and empty-table column deletion finish with `0/0` mod files. 
The RPC path, information-table routing, admission messages, 
backward-compatible persistence, and regression coverage are included.
   
   Validation of the final column-progress update:
   
   - 32 targeted unit tests passed, with no failures, errors, or skips.
   - Both new column-progress ITs passed in 1C1D, with no failures, errors, or 
skips.
   - Clean English `verify -pl integration-test -am -P 
with-integration-tests,TableClusterIT` passed all 3 mod-progress IT cases, with 
no failures, errors, or skips. Reports and node logs confirm 1C3D and 
multi-node query verification.
   - Clean Chinese test compilation of ConfigNode and its IoTDB dependency 
closure, Spotless, `git diff --check`, message-key/placeholder parity, and IT 
discovery passed.
   - Full-reactor builds, complete distribution packaging, the remaining 
affected IT matrix, and leader-switch race scenarios were not run. Earlier 
tree-deletion results in the description are historical.
   
   Reviewed source head: `971feafe81b9dec11a115f36cedfb8b715aa3aa2`.
   Final local commit: `5a50867adb08f638f2d5c7a74532045bf8d97af7`.
   Confirmed remote source-branch and PR head: 
`5a50867adb08f638f2d5c7a74532045bf8d97af7` (both match the final local commit).
   
   This was a scoped fix round, not an independent review of the full PR. The 
PR remains a draft pending a fresh independent review of the complete latest 
diff. Remote CI was not awaited.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to