Caideyipi commented on PR #19186:
URL: https://github.com/apache/iotdb/pull/19186#issuecomment-6792501927

   Independent re-review completed in this session (one round). Three P2 
behavioral findings were fixed and pushed. The PR remains **Draft** pending a 
fresh independent re-review.
   
   - Comparison baseline: `971feafe81b9dec11a115f36cedfb8b715aa3aa2`.
   - Reviewed PR/source head: `1af99c45596be2b983b7cc9057b376b3c5dad5d5`.
   - Final local commit and confirmed source-branch/PR head: 
`a4ff94d3fe86e9df85828f61dc5c4b3c9f54e686`.
   
   **Original column-progress and RPC changes**
   
   1. **P2: column deletion reported a terminal result before durable 
completion.** While terminal consensus persistence was being retried, the 
public progress listing could already expose `SUCCESS` or `ROLLEDBACK`. The 
listing now reports `RUNNABLE / FINALIZING` until the executor retains the 
completed result, preserving the error and mod-file counters. Regression 
coverage checks both terminal outcomes, including actual blocked persistence 
paths. See 
[ProcedureManager.java](https://github.com/apache/iotdb/blob/a4ff94d3fe86e9df85828f61dc5c4b3c9f54e686/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java#L3028).
   2. **P2: completing tasks could disappear from a progress query.** The lazy 
active-task stream was consumed after the completed-task snapshot had already 
been taken. Completion between those reads could therefore miss both 
collections. Column and shared `DROP TABLE` listings now use the existing eager 
active-first snapshot helper, retaining procedure-ID deduplication. A 
deterministic regression exercises both listings. See 
[ProcedureManager.java](https://github.com/apache/iotdb/blob/a4ff94d3fe86e9df85828f61dc5c4b3c9f54e686/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java#L2975).
   
   The previous timeout-restoration repair was independently checked in 
dispatch cleanup, callbacks, retries and replica switching. The 
synchronous-dispatch regression now asserts the original timeout **inside 
`returnClient`**, so restoration after pool return cannot satisfy it. It passed 
without changing the starting production timeout implementation. 
Cache-invalidation broadcasts continue to use finite RPC timeouts.
   
   The requested diff and relevant call contexts were also checked for 
Region/replica counting, `NULL` versus zero counters, procedure/task 
association, concurrent and late responses, persistence and old serialization, 
view-column compatibility, information-schema registration/query paths, and 
shared table-deletion behavior. No additional confirmed finding was identified 
in those paths during this round.
   
   **Additional deletion-interval hot reload**
   
   3. **P2: a later configuration error could leave the scheduler using the old 
interval.** The descriptor can apply the interval before another setting fails 
validation. Previously, that exception skipped the scheduler update; retrying 
the same interval could skip it again. The old comparison was also captured 
before the configuration-file lock. Configuration application and scheduler 
reconciliation are now serialized, with reconciliation in `finally` against the 
effective in-memory value. Tests exercise the public configuration API, a later 
parse failure, same-value retry, invalid nonpositive values, waiting-worker 
wakeup, and interval changes while a task is already active. See 
[ConfigManager.java](https://github.com/apache/iotdb/blob/a4ff94d3fe86e9df85828f61dc5c4b3c9f54e686/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ConfigManager.java#L1987).
   
   **Verification**
   
   - Reproduced premature column terminal display and the hot-reload mismatch 
on the starting production source with regression tests: 46 tests, four 
expected assertion failures, no errors/skips. The snapshot race was separately 
reproduced before its repair.
   - Built the English ConfigNode dependency closure from clean source. After 
the last ConfigNode-only edit, cleaned and rebuilt ConfigNode and reused the 
unchanged dependencies from that exact-source build. Final-source results: **47 
tests, zero failures, errors or skips**:
   
     | Test class | Tests |
     | --- | ---: |
     | `CnToDnInternalServiceAsyncRequestManagerTest` | 4 |
     | `TimeseriesDeletionExecutionIntervalHotReloadTest` | 2 |
     | `AsyncTimeSeriesDeletionTest` | 17 |
     | `ConfigManagerTimeseriesDeletionIntervalReloadTest` | 3 |
     | `DropTableColumnProcedureTest` | 5 |
     | `DropTableProcedureTest` | 10 |
     | `DeleteTimeSeriesProcedureSchedulerTest` | 6 |
   
   - ConfigNode Spotless apply and `git diff --check` passed. New tests added 
in this session ran remotely; they were not run locally. An initial regression 
attempt stopped at a wrong import in a newly written test; that import was 
corrected before the reported test executions.
   - ITs, Chinese compilation, a full build and the complete regression suite 
were **not run on the final commit**. Historical results from earlier snapshots 
are not counted as final-commit reruns. Remote CI was not awaited.
   - Immediately before pushing, the PR was still Draft and both PR/source 
heads matched the reviewed SHA. The update was guarded against a changed source 
ref. After pushing to `Caideyipi/iotdb:feature/async-schema-deletion`, both 
heads were confirmed equal to the final local commit above; Draft status was 
retained.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to