Caideyipi commented on PR #19186:
URL: https://github.com/apache/iotdb/pull/19186#issuecomment-6813124852

   ## Independent Review Summary
   
   Compared with base `971feafe81b9dec11a115f36cedfb8b715aa3aa2`; reviewed PR 
head `ddaaaed71d92e8f8cc15e5491e892b8df530f849`.
   
   Found one test-logic issue at 
[`DeleteTimeSeriesProcedureSchedulerTest.java:93`](https://github.com/Caideyipi/iotdb/blob/a4894c01a9fc43e32a3c364e09752b95d47ce6a8/iotdb-core/confignode/src/test/java/org/apache/iotdb/confignode/procedure/scheduler/DeleteTimeSeriesProcedureSchedulerTest.java#L93).
 The latch was released before the worker entered `scheduler.poll()`, so the 
short future timeout could expire before polling began and let the test pass 
without exercising a waiting worker. The test now waits until the worker is 
`TIMED_WAITING` and confirms the future is still incomplete before reloading 
the interval.
   
   No source-behavior issue was confirmed in the complete PR diff.
   
   Final local commit and confirmed source/PR head: 
`a4894c01a9fc43e32a3c364e09752b95d47ce6a8`.
   
   Verification: Spotless apply and `git diff --check` passed. The focused 
scheduler test did not execute on the final commit: remote Maven builds stopped 
before compilation because `org.apache:apache:pom:33` was unavailable in the 
dependency cache and Maven Central was unreachable. No local tests were run; 
earlier results at the reviewed SHA are not counted as validation of the final 
commit.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to