Caideyipi commented on PR #19186:
URL: https://github.com/apache/iotdb/pull/19186#issuecomment-6793111468

   Independent re-review completed in this session (one round). One P2 
behavioral finding was repaired. The PR remains **Draft** pending a fresh 
independent re-review.
   
   - Comparison baseline: `971feafe81b9dec11a115f36cedfb8b715aa3aa2`.
   - Reviewed PR/source head: `a4ff94d3fe86e9df85828f61dc5c4b3c9f54e686`.
   - Final local commit and confirmed source-branch/PR head: 
`ddaaaed71d92e8f8cc15e5491e892b8df530f849`.
   
   **Original column-progress and RPC changes**
   
   1. **P2: a transition during column-progress listing could bypass the 
durable-completion guard.** The listing read `state` first and `progress` 
later. If execution entered `SUCCESS` or `ROLLEDBACK` between those reads, the 
earlier nonterminal state bypassed the `FINALIZING` guard while the later read 
exposed terminal progress, even though terminal persistence could still be 
retrying. The repair captures progress before checking terminal state and 
derives both terminal display fields from that checked state. The new 
deterministic regression exercises both terminal outcomes before and after 
executor completion. See 
[ProcedureManager.java](https://github.com/apache/iotdb/blob/ddaaaed71d92e8f8cc15e5491e892b8df530f849/iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java#L3028)
 and 
[AsyncTimeSeriesDeletionTest.java](https://github.com/apache/iotdb/blob/ddaaaed71d92e8f8cc15e5491e892b8df530f849/iotdb-core/confignode/src/test/java/org/apache/iotdb/c
 onfignode/manager/AsyncTimeSeriesDeletionTest.java#L519).
   
   The full current diff and relevant callers were inspected, including 
synchronous dispatch exceptions and timeout restoration **before pool return**, 
success/error callbacks, retries, replica switching and finite 
cache-invalidation broadcasts. Region deduplication, executing-replica counts, 
unknown versus zero values, procedure/task IDs, concurrent and late responses, 
persistence and old formats, view-column compatibility, information-schema 
registration/query/filtering, terminal errors, and the shared `DROP TABLE` 
progress helper and eager snapshots were checked. No additional confirmed 
finding was identified in those paths. The earlier timeout, snapshot and 
persistence repairs and their regression logic were checked independently.
   
   **Additional deletion-interval hot reload**
   
   No new confirmed finding. Checked configuration applicability and 
positive-value validation, serialized configuration application, reconciliation 
in `finally` after later validation errors and same-value retries, executor 
initialization/reload synchronization, waiting-worker wakeup, interval 
increases/decreases, and preservation of active-task concurrency slots.
   
   **Verification**
   
   - The new regression reproduced the issue on the reviewed production source: 
one test, one expected assertion failure (`FINALIZING` versus `SUCCESS`), no 
errors/skips.
   - Built the required TsFile source and the 29-module English ConfigNode 
dependency closure from clean source. After the ConfigNode-only repair, 
cleaned/rebuilt ConfigNode and reused only unchanged dependencies from that 
exact-source build. Final-source English results: **50 tests, zero failures, 
errors or skips**:
   
     | Selection | Tests |
     | --- | ---: |
     | `CnToDnInternalServiceAsyncRequestManagerTest` | 4 |
     | `TimeseriesDeletionExecutionIntervalHotReloadTest` | 2 |
     | `AsyncTimeSeriesDeletionTest` | 18 |
     | `ConfigManagerTimeseriesDeletionIntervalReloadTest` | 3 |
     | `DropTableColumnProcedureTest` | 5 |
     | `DropTableProcedureTest` | 10 |
     | `DeleteTimeSeriesProcedureSchedulerTest` | 6 |
     | `DropViewColumnProcedureTest` | 1 |
     | `DataRegionTest#testDropColumnModFileProgress` | 1 |
   
   - Clean Chinese `test-compile` of the complete ConfigNode dependency closure 
passed on the final source. ConfigNode Spotless apply and `git diff --check` 
passed.
   - Executable tests and compilation ran remotely; no local tests were run. No 
cluster ITs, full distribution build or complete regression suite were run on 
the final source. The starting-source dependency installation also ran one 
pre-existing `EnvScriptIT` successfully; that is not counted as a final-source 
IT rerun. Historical results are not treated as reruns. Remote CI was not 
awaited.
   - Immediately before pushing, the PR remained Draft and both PR/source heads 
matched the reviewed SHA. The push to 
`Caideyipi/iotdb:feature/async-schema-deletion` was guarded against a changed 
source ref. After pushing, both heads were confirmed equal to the final local 
commit above, with Draft status retained.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to