Caideyipi commented on PR #19186:
URL: https://github.com/apache/iotdb/pull/19186#issuecomment-6791649097

   ## Independent review: two-patch scope
   
   This round reviewed only `5a50867adb08f638f2d5c7a74532045bf8d97af7` 
(column-deletion procedure, execution phase, and mod-file progress) and 
`2686b541cf22021dae6514dd3c5fa3c5f2836676` (internal deletion RPC timeout 
policy), against `971feafe81b9dec11a115f36cedfb8b715aa3aa2`. The reviewed 
PR/source head was `2686b541cf22021dae6514dd3c5fa3c5f2836676`. Final local 
commit, confirmed source-branch head, and confirmed PR head are all 
`1af99c45596be2b983b7cc9057b376b3c5dad5d5`. The PR remains Draft.
   
   **Finding (P2, fixed):** In `AsyncRequestManager.java:230` and 
`CnToDnInternalServiceAsyncRequestManager.java:588`, a synchronous exception 
while dispatching a deletion RPC after its deadline was disabled could return 
the pooled client without restoring its configured timeout. The next borrower 
could then inherit the unbounded timeout for unrelated requests. The 
pre-dispatch cleanup now restores the original timeout before returning the 
client, and a regression test covers this failure path.
   
   No other confirmed issues were found in the two-patch scope. The review 
checked progress aggregation and per-Region replica deduplication, 
procedure/task correlation under retries and replica changes, persistence and 
older serialized state, view-column compatibility, information-schema 
registration/RPC/routing/result fields, error and terminal-state reporting, 
long-running deletion RPC deadlines, bounded cache-invalidation broadcasts, and 
shared `DROP TABLE` behavior.
   
   A separate user-requested change in the final update makes 
`timeseries_deletion_execution_interval_ms` hot reloadable and wakes a waiting 
deletion scheduler. It is outside the two-patch review conclusion and is 
included in the next independent review scope.
   
   **Verification:** On final candidate 
`1af99c45596be2b983b7cc9057b376b3c5dad5d5`, a clean English ConfigNode 
dependency-closure test run passed all four focused test classes: 12 tests, 0 
failures, 0 errors, 0 skipped. Spotless apply for ConfigNode and node-commons 
passed with no formatting changes. At 
`5a50867adb08f638f2d5c7a74532045bf8d97af7`, the earlier focused tests, 
1C1D/1C3D ITs, and English/Chinese dependency-closure compiles passed; at 
`2686b541cf22021dae6514dd3c5fa3c5f2836676`, the clean English 
dependency-closure compile and focused unit tests passed. Those results belong 
to their stated snapshots.
   
   The 1C1D/1C3D ITs, Chinese compile, full build, and full regression were not 
rerun on the final candidate. A separate clean remote build attempt could not 
resolve Maven Surefire from Maven Central and did not execute tests. Remote CI 
was not awaited. A fresh independent review is required after this behavior 
fix; the PR remains Draft.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to