Caideyipi commented on PR #17666:
URL: https://github.com/apache/iotdb/pull/17666#issuecomment-6843203852

   ### Independent re-review
   
   Reviewed SHA: `df8d30d4215d9d662831801925a982c023c74c93`. I found one 
remaining lifecycle race: an event update could pass the Pipe-alive check, then 
insert a remaining-event metric operator after drop had removed the Pipe and 
deregistered its metrics. Commit `d7e2c2e00e9fc249a9036848ade31fa43f10be8f` 
serializes the missing-operator creation path with deregistration.
   
   Validation: Spotless passed. A clean 28-module reactor compiled, including 
all DataNode sources, but `forbiddenapis` failed while reading a dependency 
archive (`ZipFile invalid LOC header`) before tests ran, so the updated test 
result is unverified. On the preceding SHA, `PipeMetricsRestartTest` passed all 
11 tests. CI for the final SHA was pending when checked and was not awaited.
   
   The PR remains draft pending a fresh independent review of the updated head.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to