Caideyipi commented on PR #17666:
URL: https://github.com/apache/iotdb/pull/17666#issuecomment-6848040213

   ### Independent re-review
   
   Reviewed PR head `33e41a31cf344bdba5be549069a446071138258b` against target 
base `673434b3335f68f0e4ef00de7323472a3121e136`, focusing on 
`d7e2c2e00e9fc249a9036848ade31fa43f10be8f`. This round found and fixed 
behavioral and test-logic issues:
   
   - A late metric update could pass the liveness check and recreate its 
operator after deregistration. Creation now rechecks the exact pipe instance 
while serialized with deregistration; a deterministic concurrent regression 
test covers metadata deletion and deregistration interleaving.
   - Endpoint rate limiter state is now cleared only when the whole pipe is 
dropped.
   - Floating-memory counter updates and cleanup are serialized per pipe 
instance so a concurrent drop cannot lose a late increment.
   - Late event enrichment no longer recreates committer restart state after 
pipe cleanup.
   
   Added deterministic unit regressions for these lifecycle cases. No cluster 
IT was added because the internal metric-map ordering cannot be controlled or 
observed deterministically from a cluster test without adding production test 
hooks; the latch-based unit test exercises the exact race.
   
   Validation: `mvn spotless:apply -P with-integration-tests` passed. The 
focused offline clean reactor test run passed all 31 tests (12 node-commons and 
19 DataNode) with `-Dforbiddenapis.skip=true`. A separate clean 28-module 
compile reached DataNode sources but forbiddenapis failed before tests with 
`ZipFile invalid LOC header` in a dependency archive. A remote rerun could not 
reach Maven Central/JitPack. The final GitHub check snapshot had 39 checks: 38 
queued and 1 in progress; CI was not awaited.
   
   Final local SHA: `6f2cc670214385796d95b94d27db34384b78534e`.
   Confirmed source branch `apache/iotdb:potential-leak` SHA and PR head SHA: 
`6f2cc670214385796d95b94d27db34384b78534e`.
   
   The PR remains draft because this round found behavioral/test-logic issues. 
Please perform a fresh independent re-review of the updated full diff.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to