Caideyipi commented on PR #17666:
URL: https://github.com/apache/iotdb/pull/17666#issuecomment-6906651704

   Round 2 re-review: Apache IoTDB PR #17666
   
   Reviewed head: 06f675ca98f7daa36d666dae74abf4e31cf6f6f1
   Updated head: bd13b0cd21b431224daa4d97b9b3eaa9032f2ece
   PR state: OPEN draft; base master; head potential-leak
   
   This review found and fixed Pipe drop lifecycle races:
   
   - PipeTaskAgent.cleanupFloatingMemoryUsageCounterIfUnused now removes unused 
floating-memory accounting state without scanning Pipe metadata on event 
release. Tests cover balanced acquisition and release after drop.
   - Drop-aware liveness prevents late metric updates and endpoint rate-limiter 
creation from recreating per-Pipe state after deregistration.
   - A late PipeEventCommitManager.isCurrentCommitterKey lookup could 
repopulate restart-generation state through computeIfAbsent after concurrent 
clear. It now performs a read-only restart lookup and verifies committer 
identity. A latch-controlled test covers the clear/lookup interleaving.
   
   Validation: Spotless passed. The clean offline 23-module reactor completed, 
but its method-level selector ran zero tests for the parameterized 
PipeEventCommitManagerTest; the selector was corrected to run the full class, 
and all 10 tests passed, including the new race test under INFO and DEBUG. The 
previously reported PipeTaskAgentTest#testPipeDropClearsSharedRuntimeState and 
37 offline targeted tests passed. forbiddenapis was skipped because the 
existing dependency archive is corrupt. Remote reactor validation was stopped 
because JitPack was unreachable and Apache snapshots timed out. PR CI was not 
awaited.
   
   Because this round found and fixed behavior issues, the PR remains draft for 
a fresh-session re-review. Do not repeat the full review in this session or 
mark the PR ready.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to