Caideyipi commented on PR #17666:
URL: https://github.com/apache/iotdb/pull/17666#issuecomment-6852066355

   ### Independent re-review
   
   Reviewed the full current diff at head 
`ca5d222e2265078b9fcd0ffc48b23b4ea308b8c9` against `master`. Follow-up finding: 
the previous whole-pipe cleanup was still limited to `PipeDataNodeTaskAgent` 
overrides. ConfigNode drops use the shared `PipeTaskAgent.dropPipe` overloads, 
so they could retain event committer and endpoint rate-limiter entries. Cleanup 
now runs from both shared overloads, and the DataNode duplicates were removed 
([common drop 
path](https://github.com/apache/iotdb/blob/06f675ca98f7daa36d666dae74abf4e31cf6f6f1/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/PipeTaskAgent.java#L665),
 [cleanup 
helper](https://github.com/apache/iotdb/blob/06f675ca98f7daa36d666dae74abf4e31cf6f6f1/iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/agent/task/PipeTaskAgent.java#L1325),
 [DataNode 
path](https://github.com/apache/iotdb/blob/06f675ca98f7daa36d666dae74abf4e31cf6f6f1/iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent
 /task/PipeDataNodeTaskAgent.java#L419)). The added unit regression covers both 
drop overloads and checks the shared maps 
([test](https://github.com/apache/iotdb/blob/06f675ca98f7daa36d666dae74abf4e31cf6f6f1/iotdb-core/node-commons/src/test/java/org/apache/iotdb/commons/pipe/agent/task/PipeTaskAgentTest.java#L200)).
   
   Verification: `mvn spotless:apply -P with-integration-tests` passed. The 
offline clean reactor passed with the new regression test (1 test, 0 
failures/errors/skips, 23 reactor modules); `-Dforbiddenapis.skip=true` was 
used because of the known damaged dependency archive. The remote attempt was 
stopped after the build host could not reach JitPack and timed out against 
Apache snapshots for the TsFile SNAPSHOT. No cluster IT was added because this 
shared cleanup is deterministic to cover in a unit test without production test 
hooks. PR CI was not awaited.
   
   Final commit and confirmed source branch/PR head: 
`06f675ca98f7daa36d666dae74abf4e31cf6f6f1`. The PR remains draft because this 
round found a behavior issue and requires a fresh independent re-review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to