Caideyipi commented on PR #17666:
URL: https://github.com/apache/iotdb/pull/17666#issuecomment-6842703887

   Review round of `5f71bb0d0e6` found one remaining lifecycle leak: `SHOW 
PIPE` can fall back to DataNode metrics after receiving a pipe row from 
ConfigNode. If the pipe is dropped between those steps, 
`getRemainingEventAndTime()` previously used `computeIfAbsent` and recreated a 
per-pipe operator after deregistration.
   
   Commit `df8d30d4215` changes the query to read existing operator state only 
and return zero when absent. I added the stale-query assertion to 
`testSinglePipeMetricsIgnoreLateEventsAfterDeregister`.
   
   Validation: clean reactor test for `PipeMetricsRestartTest` passed (28 
modules, 11 tests). Checks on the updated head were in progress when reviewed; 
CI was not awaited.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to