David Ribeiro Alves has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4471/3/src/kudu/integration-tests/all_types-itest.cc File src/kudu/integration-tests/all_types-itest.cc: Line 218: // Set the flush threshold low so that there are flush events which grammar changes like this are subjective, we usually avoid doing them if you're not actually touching that part of the code. Fixing typos and grammar errors is ok, but rephrasing stuff differently should be avoided as it's polluting the history. I for one prefer the previous version, since I don't recall we calling flushes "flush events" anywhere else. Line 222: // Set the major delta compaction ratio low enough so that the test I'm ambivalent whether the grammar change is justified. Line 227: // once KUDU-1631/KUDU-1346 is fixed. It's necessary to change the default you mean KUDU-1632, not KUDU-1631. Maybe mark KUDU-1632 as a dup of KUDU-1346 and close the former? PS3, Line 231: --consensus_max_batch_size_bytes=2097152 have you tested that this doens't trigger the check. How big can single tablet batches get? -- To view, visit http://gerrit.cloudera.org:8080/4471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
