Alexey Serbin has posted comments on this change. Change subject: [tests] MANUAL_FLUSH --> AUTO_FLUSH_BACKGROUND ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/4471/3/src/kudu/integration-tests/all_types-itest.cc File src/kudu/integration-tests/all_types-itest.cc: PS3, Line 231: --consensus_max_batch_size_bytes=2097152 > yeah, in that case, I'm just afraid this will get flaky, but I guess we can Well, it did not expose flakiness in dist_test so far. But let's see. http://gerrit.cloudera.org:8080/#/c/4471/5/src/kudu/integration-tests/alter_table-test.cc File src/kudu/integration-tests/alter_table-test.cc: Line 264: > if this is the next row now can you change the variable name? Good idea! Will do. -- To view, visit http://gerrit.cloudera.org:8080/4471 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieafc198609cceb5d6945a910364056d81786629a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
