Alexey Serbin has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4594/1/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: Line 504: *stdout_out = std::move(outv.front()); > Isn't that redundant if we are already checking for outv.size() as per your Yep, exactly. I wrote this comment before commenting on outv.capacity(). So, once there is a check on 'outv' size in accordance with 'fds' contents, that's not needed. Line 507: *stderr_out = std::move(outv.back()); > same as above. Yep, the same response as above. -- To view, visit http://gerrit.cloudera.org:8080/4594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
