Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4594/2/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS2, Line 139: SimpleItoa(std::rand()) > I agree with Alexey (and I wrote the same on PS1): generating a random stri Thanks Adar, agreed on rand() part. I think Alexey & I were discussing a slightly different topic earlier; i.e whether or not we want to be checking stderr content at all. My argument was we want to because we may have collected a garbage in stderr if the program didn't SIGSEGV. I also didn't want to rely on an error code which came out as EACCESS via SubProcess::Call("/"). After some offline discussions, we updated the stderr to be more deterministic. In this case we know certainly: 1) Program has executed via execve(unlike EACCESS case) 2) It has also captured a well-defined string in stderr -- To view, visit http://gerrit.cloudera.org:8080/4594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
