Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4594/2/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS2, Line 139: SimpleItoa(std::rand()) > I don't think it's worth analyzing the stderr in the context of this test: We are better off checking little more than no SIGSEGV here, to make sure we don't have garbage stashed in stderr. Previously I had run 50k iterations of original patch without hitting anything, but one of the jenkins run had caught sigsegv. I am sure you would get a different error if you are running on a VM with root privileges for "/" command. In any case, I can include a simpler version than 'bash -c' if you feel this is too fancy, but checking for sanity output of stderr is important IMHO. -- To view, visit http://gerrit.cloudera.org:8080/4594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <d...@cloudera.com> Gerrit-Reviewer: Dinesh Bhat <din...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
