Alexey Serbin has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4594/2/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS2, Line 139: SimpleItoa(std::rand()) > It's true that there are simpler alternatives; I wanted to pick a generic c I don't think it's worth analyzing the stderr in the context of this test: other (e.g., next one) version of bash could output something else instead of 'command not found'. Checking !s.ok() would be enough: all we want is to check is that Subprocess::Call() does not die with SIGSEGV, right? But it's all up to you. I just wanted to point it's possible to check that the Subprocess::Call() does not SIGSEGV by a simpler means. BTW, in my case, running Subprocess::Call("/", ...) with and without super-user privileges output the same 'Couldn't exec /: Permission denied [13]' and I wouldn't expect it to be different depending on access level. -- To view, visit http://gerrit.cloudera.org:8080/4594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
