Dinesh Bhat has posted comments on this change. Change subject: KUDU-1674: Fix SubProcess:Call SEGV when trying to capture stderr alone ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4594/2/src/kudu/util/subprocess-test.cc File src/kudu/util/subprocess-test.cc: PS2, Line 139: SimpleItoa(std::rand()) > Why do you need such an intricate stuff? If you want something which is gu It's true that there are simpler alternatives; I wanted to pick a generic command valid across all unix platforms irrespective of modes. For eg, above command outputs 'permission denied' on mac with user privileges and 'command not found' if I am running it with sudo privileges. I think if we are simply checking stderr.empty() it should be okay. I can change it to that if you are advocating KISS. -- To view, visit http://gerrit.cloudera.org:8080/4594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67bd462098526a9ba032669b621b8139b56ee5b8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
