Adar Dembo has posted comments on this change. Change subject: Add krb5 to thirdparty ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: PS1, Line 557: Kudu does not link : # against the built libraries for security reasons. Well, Kudu doesn't actually need to build against it; Kudu's security dependency list terminates with gssapi, right? Line 560: echo $KRB5_BDIR Nit: drop this, debugging only right? http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-thirdparty.sh File thirdparty/build-thirdparty.sh: PS1, Line 24: # * /thirdparty/installed/common - prefix directory for libraries and binary tools : # common to all build types, e.g. CMake, : # krb5, C dependencies. We should update this; C dependencies (and libraries) are no longer found here, just tools. Line 105: if [ "$PREFIX_DIR" != "$PREFIX_COMMON" ]; then May need to remove this now, since we're actually putting stuff in PREFIX_COMMON/lib once again. http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: Line 256: fetch_and_expand ${KRB5_NAME}.tar.gz Huh, I wonder why I didn't use FOO_NAME in the rest of the entries here. Seems like an oversight. Would you mind fixing that? -- To view, visit http://gerrit.cloudera.org:8080/4727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I444c7da5a24fc9d554f542f300586b921cd65b6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
