Alexey Serbin has posted comments on this change.

Change subject: Add krb5 to thirdparty
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 564:   $KRB5_SOURCE/src/configure --prefix=$PREFIX
> Dan and I discussed this: if Kudu doesn't include any krb5 headers nor link
BTW, if we still have any concerns regarding this, it's possible to use 
--includedir option for configure.  It's possible to point it to some 
non-standard subdir (or to a temporary directory and then remove it after 
build).

I remember Dan didn't like the idea of having manual pages and other stuff 
installed.  To get rid of that, it's possible to point --datarootdir 
configure's option to some temporary directory and then remove if after build 
is done.


-- 
To view, visit http://gerrit.cloudera.org:8080/4727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444c7da5a24fc9d554f542f300586b921cd65b6e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to