Todd Lipcon has posted comments on this change.

Change subject: Add krb5 to thirdparty
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

Line 564:   $KRB5_SOURCE/src/configure --prefix=$PREFIX
> BTW, if we still have any concerns regarding this, it's possible to use --i
I guess the includes actually aren't as problematic (since we wouldn't be 
including them), but libraries are potentially problematic if they end up 
dynamically loaded. For example, SASL will probably dynamically load 
libkrb5.so, and we want it to pick up the system version, not the one that we 
installed.


-- 
To view, visit http://gerrit.cloudera.org:8080/4727
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I444c7da5a24fc9d554f542f300586b921cd65b6e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to