Adar Dembo has posted comments on this change. Change subject: Add krb5 to thirdparty ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 564: $KRB5_SOURCE/src/configure --prefix=$PREFIX > does this end up putting the includes on our build's include path? I think Dan and I discussed this: if Kudu doesn't include any krb5 headers nor link against krb5 libraries, what difference does it make? -- To view, visit http://gerrit.cloudera.org:8080/4727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I444c7da5a24fc9d554f542f300586b921cd65b6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
