Adar Dembo has posted comments on this change. Change subject: Add krb5 to thirdparty ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4727/1/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: Line 564: $KRB5_SOURCE/src/configure --prefix=$PREFIX > I guess the includes actually aren't as problematic (since we wouldn't be i As long as we avoid -Wl,-rpath=PREFIX_COMMON/lib (which we don't have today) when building the thirdparty dependencies and Kudu itself, that shouldn't happen. But, I can understand wanting more certainty here, to avoid it silently slipping in. -- To view, visit http://gerrit.cloudera.org:8080/4727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I444c7da5a24fc9d554f542f300586b921cd65b6e Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
