Jean-Daniel Cryans has posted comments on this change. Change subject: MiniKdc for Java ......................................................................
Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/4788/1/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java: Line 1: package org.apache.kudu.client; Missing license. PS1, Line 28: An nit: A Line 30: */ Maybe explain how this class works? Like it uses external processes for about everything, how it does it, etc. PS1, Line 132: potentially race nit: race-prone? PS1, Line 178: C nit: c Line 322: private static String getBinaryPath(String executable, List<String> searchPaths) throws IOException { nit: long line http://gerrit.cloudera.org:8080/#/c/4788/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestMiniKdc.java: Line 1: package org.apache.kudu.client; Missing license. -- To view, visit http://gerrit.cloudera.org:8080/4788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
