Dan Burkert has posted comments on this change. Change subject: MiniKdc for Java ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java: PS2, Line 54: 64530 > How did you pick this value? It's offset by 500 from MiniKuduCluster.PORT_START. I don't know the provenance of MiniKuduCluster.PORT_START. Line 125: if (!dataRootDir.exists()) { > Hmm, so if the data root exists, we'll try to reuse the KDB and configs tha Yes. This is to support start/stop/start of a single KDC. Line 274: public void close() throws IOException { > Can you consolidate the stop() and close() implementations? Done Line 281: FileUtils.deleteDirectory(options.dataRoot.toFile()); > I think this belongs in the finally clause. Done PS2, Line 318: LOG.trace("executing {}: {}", Paths.get(argv[0]).getFileName(), Joiner.on(' ').join(args)); > Consider moving this log line into startProcessWithKrbEnv() method. There are calls to buildProcessWithKrbEnv that don't go through startProcessWithKrbEnv that it's helpful to log. PS2, Line 329: Process process, String name > Would it make sense to make a sub-class of the Process class, so it would b Maybe, but I think it would be a lot of boilerplate just to avoid a single parameter to a private method. -- To view, visit http://gerrit.cloudera.org:8080/4788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
