Dan Burkert has posted comments on this change. Change subject: MiniKdc for Java ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4788/2/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS2, Line 128: RETURN_NOT_OK(Env::Default()->CreateDir(options_.data_root)); > Nit: it seems this directory is kind of synchronization point between Java The Java and C++ MiniKdc instances will not share a directory. Each instance gets a unique directory. The MiniKdc is not meant to be shared, so this method doesn't account for concurrency. The check is just to see if this MiniKdc has previously been started, or if this is the first time. -- To view, visit http://gerrit.cloudera.org:8080/4788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
