Alexey Serbin has posted comments on this change. Change subject: MiniKdc for Java ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java: PS2, Line 318: LOG.trace("executing {}: {}", Paths.get(argv[0]).getFileName(), Joiner.on(' ').join(args)); > There are calls to buildProcessWithKrbEnv that don't go through startProces Ah, I see. The message looked misleading to me since I saw it was not executing the binary right here. But if it's good enough, that's fine. PS2, Line 329: Process process, String name > Maybe, but I think it would be a lot of boilerplate just to avoid a single ok, that sounds reasonable. http://gerrit.cloudera.org:8080/#/c/4788/2/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS2, Line 128: RETURN_NOT_OK(Env::Default()->CreateDir(options_.data_root)); Nit: it seems this directory is kind of synchronization point between Java MiniKDC and C++ MiniKDC. However, what if an error encountered while creating files in the directory? Also, what if the directory has just been created by the concurrent Java MiniKDC, then it might be a race to complete writing configs and reading them. Besides, the scheme (try to create if not exist) is racy. May be, just try to create a directory and then check for the status code (like if it's Status::AlreadyPresent, then back off)? -- To view, visit http://gerrit.cloudera.org:8080/4788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
