Adar Dembo has posted comments on this change. Change subject: MiniKdc for Java ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java File java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java: PS2, Line 54: 64530 How did you pick this value? Line 125: if (!dataRootDir.exists()) { Hmm, so if the data root exists, we'll try to reuse the KDB and configs that are in there? Is that what the C++ implementation does too? Line 274: public void close() throws IOException { Can you consolidate the stop() and close() implementations? Line 281: FileUtils.deleteDirectory(options.dataRoot.toFile()); I think this belongs in the finally clause. -- To view, visit http://gerrit.cloudera.org:8080/4788 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
