David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset ......................................................................
Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/6//COMMIT_MSG Commit Message: PS6, Line 18: Flush -> Row now lives in RS1 : Delete Row at 3 -> Row is now a ghost in RS1 : Insert Row at 3 -> Row goes in the MRS again : D > not following how this part of the sequence could happen. A single operatio yeah, I was trying to simplify the sequence and apparently simplified it to a point where it's impossible to happen :) fixed this and also illustrated the sequence in the test. -- To view, visit http://gerrit.cloudera.org:8080/4994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab52a1aa68494218f91f3acd31ef8ddf352bd57 Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
