David Ribeiro Alves has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/9//COMMIT_MSG Commit Message: Line 28: for the row. > Yea, I agree it's impossible to establish which one is older, but you can o yeah, I had considered that (both are deleted and really close to the ahm so likely not observable, which is why I didn't come up with a user observable scenario) but honestly I really like the check that makes sure we can always establish which version of a row comes first. Specially as we historically miss some edge cases. So it was between giving that up or doing something super silly (like making sure both rows are exactly in this scenario at which point why would they be in the compaction input anyway) or adding this. I think adding this is unimpactful since the row is unobservable anyway. -- To view, visit http://gerrit.cloudera.org:8080/4994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab52a1aa68494218f91f3acd31ef8ddf352bd57 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
