Todd Lipcon has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset ......................................................................
Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4994/9//COMMIT_MSG Commit Message: Line 28: for the row. > (unrelated nit) Isn't it more like: Yea, I agree it's impossible to establish which one is older, but you can only get to this situation when the AHM has moved above 3 (such that you are removing the UNDO @ 3). Given that, no one can ever read this base data, so it doesn't actually matter which one you pick, does it? Was thinking an end-to-end test that does the above sequence at a tablet level would be a good way to show what happens without the patch and why it causes a problem (some incorrect scan results or whatever) -- To view, visit http://gerrit.cloudera.org:8080/4994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab52a1aa68494218f91f3acd31ef8ddf352bd57 Gerrit-PatchSet: 9 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Jean-Daniel Cryans <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
