Todd Lipcon has posted comments on this change. Change subject: Don't output unobservable rows from the MemRowset ......................................................................
Patch Set 11: I'm still a little worried about the "manufactured" nature of this test. Is this scenario produced by any higher level test? eg the fuzz tests, etc? Do we have coverage for the other similar scenario: initial state -------------- DRS 1: undo: delete @2 base: v1 MRS empty ------- txn @3: delete, insert v2 ---------- DRS 1: undo: del @ 2 base: v1 redo delta: del @3 MRS: undo: del @3 base: v2 ----- flush MRS, AHM = 5 ------- DRS 1: undo: del @ 2 base: v1 redo delta: del @3 DRS 2: base: v2 ---------------- flush and compact --------------- ? -- To view, visit http://gerrit.cloudera.org:8080/4994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieab52a1aa68494218f91f3acd31ef8ddf352bd57 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
