Adar Dembo has posted comments on this change. Change subject: [client-test] ServiceUnavailable retry scenario ......................................................................
Patch Set 7: Code-Review+2 (1 comment) Clever test parameterization. http://gerrit.cloudera.org:8080/#/c/5974/7/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 4721: MonoDelta::FromSeconds(2), To avoid flakiness, maybe set this one a little higher, or set the client timeout a little lower, or both? I get that you don't want this to be too high because it draws out the test runtime, but the delta between the two seems too low to me. -- To view, visit http://gerrit.cloudera.org:8080/5974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief82add7b36c1f3875ea77e7f7503f6fb552838c Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
