Alexey Serbin has posted comments on this change. Change subject: [client-test] ServiceUnavailable retry scenario ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5974/2/src/kudu/master/mini_master.cc File src/kudu/master/mini_master.cc: Line 153: Status MiniMaster::StartDistributedMasterOnPorts(uint16_t rpc_port, uint16_t web_port, > ok, will do. I just tried to keep the order of the methods in the implementation file to be consistent with the order of their declaration. http://gerrit.cloudera.org:8080/#/c/5974/2/src/kudu/master/mini_master.h File src/kudu/master/mini_master.h: PS2, Line 59: // The Init() and StartInitted() methods below are used to separate : // execution of Master::Init() and Master::StartAsync() methods, : // so it's possible to tinker with the master object in between. : Status Init(uint16_t rpc_port = 0); : Status StartInitted(); > can you clarify in the docs here that the combination of these two, in this Done -- To view, visit http://gerrit.cloudera.org:8080/5974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief82add7b36c1f3875ea77e7f7503f6fb552838c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
