Alexey Serbin has posted comments on this change. Change subject: [client-test] ServiceUnavailable retry scenario ......................................................................
Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5974/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: PS3, Line 4669: shared_ptr<KuduClient> client; : ASSERT_OK(KuduClientBuilder() : .add_master_server_addr(bound_rpc.ToString()) : .Build(&client)); > Why can't we reuse client_? Good question: I think we can re-use the existing one. Here I tried some other path in the very beginning which required a separate client. Line 4683: ASSERT_OK(cluster_->mini_master()->StartAlreadyInitted()); > Why is it important to split up Init() and Start()? Don't you still wind up My original intention was to simulate the conditions under which the non-retriable issue was observed. After some consideration I think that's not crucial. Usurping the lock via ScopedLeaderSharedLock() of fully initialized cluster does not help: it's necessary to acquire the lock in an exclusive manner if using that scenario. ok, I'll make this test acquiring the leader_lock_ in an exclusive manner. Line 4691: gscoped_ptr<KuduTableCreator> table_creator(client->NewTableCreator()); > unique_ptr Done PS3, Line 4706: gscoped_ptr > unique_ptr. Done -- To view, visit http://gerrit.cloudera.org:8080/5974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief82add7b36c1f3875ea77e7f7503f6fb552838c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
