Alexey Serbin has posted comments on this change.

Change subject: [client-test] ServiceUnavailable retry scenario
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/5974/5/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

Line 4675:       SleepFor(MonoDelta::FromSeconds(2));
> I wonder whether this will prove flaky. With only two seconds it's conceiva
Good catch.  Yes, I agree -- in this modified scenario timings have changed and 
there is more root for flakiness.  I'll update this as suggested.  Actually, 
I'm thinking to make it a parameterized test.


-- 
To view, visit http://gerrit.cloudera.org:8080/5974
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief82add7b36c1f3875ea77e7f7503f6fb552838c
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to