Adar Dembo has posted comments on this change. Change subject: [client-test] ServiceUnavailable retry scenario ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/5974/5/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: Line 4675: SleepFor(MonoDelta::FromSeconds(2)); I wonder whether this will prove flaky. With only two seconds it's conceivable for weird scheduling and/or load to delay the CreateTable() RPC until after the usurper releases the lock. Maybe the usurper can wait on a countdown latch here instead, and when CreateTable() times out below, it can release the latch so that the usurper is unblocked and releases the lock? Oh, I see you discussed that with Todd. What if, after the usurper thread is unblocked from the latch, it sleeps for another second or two? That should prevent the scenario I described above while still allowing the usurper to hold the lock as the second CreateTable() attempt begins. -- To view, visit http://gerrit.cloudera.org:8080/5974 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief82add7b36c1f3875ea77e7f7503f6fb552838c Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
