Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column ......................................................................
Patch Set 3: (4 comments) Based on my experience in the alter code, I think this should "just work" after removing the checks, as you did here. However, I also think it needs more testing. In particular, I think that we need randomized testing of primary key renaming in alter_table-randomized-test.cc, and I'd like to see coverage in alter_table-test.cc as well. http://gerrit.cloudera.org:8080/#/c/6078/3//COMMIT_MSG Commit Message: PS3, Line 9: primary key column name : to be renamed nit: renaming of primary key columns http://gerrit.cloudera.org:8080/#/c/6078/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: PS3, Line 35: import static org.junit.Assert.*; We loosely adhere to Google's Java style guide, which disallows wildcard imports (https://google.github.io/styleguide/javaguide.html#s3.3-import-statements). PS3, Line 161: // Add a row Can you add a row before the alter as well? An alter should trigger a flush, which is something I'd want to see tested with a non-empty table whose primary key is being renamed. PS3, Line 171: } Can you check the results of a scan are correct? Try using a projection on the renamed key column. -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307 Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ram Mettu <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
