Ram Mettu has posted comments on this change.

Change subject: KUDU-1890 Allow renaming of primary key column
......................................................................


Patch Set 7:

(3 comments)

Yes, Jenkins test failures are unrelated.

http://gerrit.cloudera.org:8080/#/c/6078/5/docs/known_issues.adoc
File docs/known_issues.adoc:

Line 37:   The primary key may not be changed after the table is created.
> Mention that the primary key can be renamed, since "the primary key may not
Done


http://gerrit.cloudera.org:8080/#/c/6078/6/docs/known_issues.adoc
File docs/known_issues.adoc:

PS6, Line 37: after the tab
> I don't think this helps. If you remove it, I think it will be fine, as it 
Done


http://gerrit.cloudera.org:8080/#/c/6078/6/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:

PS6, Line 3224: test renaming primary key column
> nit: test renaming primary key column
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6078
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ram Mettu <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ram Mettu <[email protected]>
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-HasComments: Yes

Reply via email to