Will Berkeley has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column ......................................................................
Patch Set 5: (1 comment) Pretty much LGTM. One small docs nit, and it looks like a security-related changelist got mixed in with this one. Can you try to extricate just your changes? I bet it'd be fine to push as is if the unrelated changes are from a commit but I'd rather not do that. Also, could you loop the randomized test a few hundred times just to check there's no failures, and note that you did so in the commit message? http://gerrit.cloudera.org:8080/#/c/6078/5/docs/known_issues.adoc File docs/known_issues.adoc: Line 37: You must drop and recreate a table to select a new primary key. Mention that the primary key can be renamed, since "the primary key may not be changed" will imply it cannot be renamed to many people. -- To view, visit http://gerrit.cloudera.org:8080/6078 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I28a8c52bdb9ac5a3661f9a07c737f7252466d307 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Ram Mettu <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Ram Mettu <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-HasComments: Yes
